fix: added inline commit lint - #442
Merged
Merged
Conversation
* fix: added inline commit lint * fix: corected the inline comment * fix: updated pylintrc * feat: Upgrade Python dependency edx-lint Bump edx-lint to latest. This will need openedx#39022 to fast-follow to prevent failing checks. Commit generated by workflow `openedx/openedx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` --------- Co-authored-by: bmtcril <112640379+bmtcril@users.noreply.github.com>
Author
|
After upgrading |
Akanshu-2u
force-pushed
the
aaich/BOMs-587-annotate-ulmo
branch
from
August 27, 2026 10:26
7d48a8f to
78d1571
Compare
rahulkanneri-2u
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the upgrade of
edx-lintto the latest version,6.2.0, a new PII annotation check has been introduced. This may result in linter issues for both true positives and false positives.This PR addresses those issues by correcting the PII annotations for true positives and adding inline comments to suppress the linter for false positives.
Changes
no_piiannotations for models that contain PII fields.Relevant PR:
Private JIRA Link:
BOMS-587